Pass disabled prop to the BaseButton in TouchableNativeFeedback
#2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tomekzaw
approved these changes
Aug 1, 2022
j-piasecki
deleted the
@jpiasecki/fix-ripple-disabled-touchable-native-feedback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
disabledprop on Touchables from Gesture Handler was not passed to theBaseButton, instead it was used to ignore incoming events. This successfully made them not callonPress*()callbacks, but in case ofTouchableNativeFeedbackit didn't disable the event handling on the native side.This PR makes
GenericTouchablepassdisabledprop further down toBaseButton, which in turn passes it to the native view, disabling touch interaction on it.Test plan
Tested on the Example app