Make grep pattern for detecting multiple installations stronger #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous pattern caused problems when library was used directly from github (not downloaded from package repository) as there were multiple package.json files with "/react-native-gesture-handler/" in their path (example applications, etc.). This commits narrows down the search to look only for "main package.json" files.
kkafar
changed the title
j-piasecki
approved these changes
Aug 18, 2022
tomekzaw
approved these changes
Aug 18, 2022
|
Good catch! 👏 Can we also have:
|
|
I partially fixed Android implementation here in this PR. Also I issued PR for Android in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previous pattern caused problems when library was used directly from GitHub (not downloaded from package repository) as there were multiple
package.jsonfiles with"/react-native-gesture-handler/"in their path (example applications, etc.).This commit narrows down the search to look only for "main package.json" files.
Test plan
Install
react-native-gesture-handlerdirectly from repository and see that it works after applying this patch.