Replace queueMicrotask
with requestAnimationFrame
#2969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
queueMicrotask
withrequestAnimationFrame
. Turns out that introducinguseLayoutEffect
(which was introduced in #2925) ended up in gestures being attached in wrong order in some cases.This can be observed in #2963 (it is highly recommended to look into repro structure):
ZoomView
where attached - they have correcttags
tags
are now-1
Pan
fromSVGMask
is attached - all handlers marked assimultaneous
havetag
-1
, therefore relations are not set uptags
In this scenario,
simultaneous handlers
array inPan
inSVGMask
was empty, effectively disabling this relation. Switching torequestAnimationFrame
solves this problem.Test plan
Verify that examples work as they used to (
draggable
,multitap
,transformations
)Also tested on code from #2963 .