Replace Omit with Pick + Exclude #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janicduplessis
pushed a commit
to janicduplessis/react-native-gesture-handler
that referenced
this pull request
Feb 16, 2020
Recently the type declarations include the use of the Omit library type. This type was added in TypeScript 3.5 (typescriptlang.org/docs/handbook/release-notes/typescript-3-5.html#the-omit-helper-type), and therefore the change prevents using this library with TypeScript projects that have not upgraded. (In my case, we use TypeScript 3.4.) I replaced the use of Omit with the same implementation based on Pick and Exclude: type Omit<T, K extends keyof any> = Pick<T, Exclude<keyof T, K>>; I'm not sure what the minimum TypeScript this project supports, but this will at least prevent issues with some earlier 3.x versions.
This was referenced Feb 28, 2020
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the type declarations include the use of the
Omitlibrary type. This type was added in TypeScript 3.5 (https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-5.html#the-omit-helper-type), and therefore the change prevents using this library with TypeScript projects that have not upgraded. (In my case, we use TypeScript 3.4.)I replaced the use of
Omitwith the same implementation based onPickandExclude:type Omit<T, K extends keyof any> = Pick<T, Exclude<keyof T, K>>;I'm not sure what the minimum TypeScript this project supports, but this will at least prevent issues with some earlier 3.x versions.