Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.13.0-rc.0 crash on iOS (animated flatlist) in Release build only #6092

Closed
karimb11 opened this issue Jun 9, 2024 · 7 comments
Closed

3.13.0-rc.0 crash on iOS (animated flatlist) in Release build only #6092

karimb11 opened this issue Jun 9, 2024 · 7 comments
Labels
Missing repro This issue need minimum repro scenario Platform: iOS This issue is specific to iOS

Comments

@karimb11
Copy link

karimb11 commented Jun 9, 2024

Description

If you scroll through a flat list that has animated items (Just a boilerplate shared value scale animation per item using Animated.View), you get this exception:

image

This happens in release build only, I also tested multiple previous versions, so it's not exclusive to the latest release of react-native-reanimated.

Steps to reproduce

I'm just looking for some pointers, it's hard to reproduce as the app is rather complex (react-navigation)

Snack or a link to a repository

don't have any

Reanimated version

3.13.0-rc.0

React Native version

0.74.2

Platforms

iOS

JavaScript runtime

Hermes

Workflow

React Native

Architecture

Fabric (New Architecture)

Build type

Release app & production bundle

Device

Real device

Device model

iPhone SE 2

Acknowledgements

Yes

@github-actions github-actions bot added the Platform: iOS This issue is specific to iOS label Jun 9, 2024
Copy link

github-actions bot commented Jun 9, 2024

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

@github-actions github-actions bot added the Missing repro This issue need minimum repro scenario label Jun 9, 2024
@szydlovsky
Copy link
Contributor

Hey @karimb11 it might be due to a recent issue with Shareables, can you please try 3.13.0-rc.1 version? It contains a fix for it

@karimb11
Copy link
Author

karimb11 commented Jun 11, 2024

Hello @szydlovsky , thank you, I tried it but still getting a crash

image

Though the exception seems different now.

@bartlomiejbloniarz
Copy link
Contributor

This was caused by an issue in jsi. I explain it more in depth here.

@Antisane76
Copy link

Hi @bartlomiejbloniarz - I'm still seeing this kind of crash error on Android Release builds using the new architecture and hermes. I originally had the same issue on iOS that was occurring here but after patching RN with your PR to RN the iOS issue was resolved.

I've seen a few functions that appear to be causing this on android in the crash logs - setNativeState, setPropertyValue, call

I have a somewhat reliable way of recreating the crash on my app so I'm happy to test any patches or ideas. I've tried 3.12.1 and 3.13.0-rc.2 of reanimated on RN 0.74.2 (with above patch) with no luck.

@bartlomiejbloniarz
Copy link
Contributor

bartlomiejbloniarz commented Jul 2, 2024

Hi @Antisane76 👋
How did you apply the patch on Android? I'm asking this question because on Android you have to configure gradle to build RN from source. Otherwise it will use precompiled artifacts.

@Antisane76
Copy link

Ah good to know. I was just using 'patch-package'. I'll give it a crack and let you know but I bet that will resolve it. Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing repro This issue need minimum repro scenario Platform: iOS This issue is specific to iOS
Projects
None yet
Development

No branches or pull requests

4 participants