Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: potentially fix iOS 16.0 navigation header title bug (#1579)
## Description Potentially fixes #1570 as suggested in [comments](#1570 (comment)). I tested it on iOS 16.0 simulator & device - worked for me. However when I passed this solution to other team @software-mansion, it was reported back to me that there is no change (buggy behaviour still occurs). I'm gonna merge this PR, as it introduces only `line-swap` change, which should not introduce any regression and potentially fixes the bug. **NOTE**: this issue seems to be already fixed internally by Apple as reported [here](react-navigation/react-navigation#10840 (comment)). ## Changes Just moved `navitem.title = ...` assignment below `navitem.titleView = ...` one. ## Test code and steps to reproduce See #1570 ## Checklist - [ ] Ensured that CI passes
- Loading branch information
Showing
6 changed files
with
10 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07d8068
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This did not fix it for me unfortunately.