Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric build fails on iOS with nightly version #1482

Closed
2 of 7 tasks
zolbooo opened this issue Jun 17, 2022 · 4 comments · Fixed by #1484
Closed
2 of 7 tasks

Fabric build fails on iOS with nightly version #1482

zolbooo opened this issue Jun 17, 2022 · 4 comments · Fixed by #1484
Labels
Missing repro This issue need minimum repro scenario Platform: iOS This issue is specific to iOS

Comments

@zolbooo
Copy link

zolbooo commented Jun 17, 2022

Description

Latest version of react-native-screens from Git (f1a8bd2 at the time of writing this issue) cannot compile because of invalid type in RNSScreenStack.mm. Since React Native 0.69.0-rc.0, MountingTransactionMetadata was removed in favor of MountingTransaction (source) in this commit.

Screenshots

--

Steps To Reproduce

  1. Create new app using RN 0.69
  2. Add react-native-screens dependency in package.json:
"react-native-screens": "software-mansion/react-native-screens#f1a8bd2"
  1. Run cd ios && USE_FABRIC=1 RCT_NEW_ARCH_ENABLED=1 pod install
  2. Run npm run ios

Expected behavior

Build should not fail

Actual behavior

Compile error in iOS build

Reproduction

Build latest version of react-native-screens from Git using steps provided above.

Platform

  • iOS
  • Android
  • Web
  • Windows
  • tvOS

Workflow

  • Managed workflow
  • Bare workflow

Package versions

package version
react-native 0.69.0-rc.6
@react-navigation/native 6.0.10
react-native-screens software-mansion/react-native-screens#f1a8bd2
react-native-gesture-handler 4.3.1
@github-actions github-actions bot added the Missing repro This issue need minimum repro scenario label Jun 17, 2022
@github-actions
Copy link

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snippet of code, a snack or a link to a GitHub repository that reproduces the problem?

@github-actions github-actions bot added the Platform: iOS This issue is specific to iOS label Jun 17, 2022
@kkafar
Copy link
Member

kkafar commented Jun 22, 2022

Hi @zolbooo!
We are aware of this issue (as it was one of our engineers who introduced this change to react-native 😄). 0.69.0 will be supported with incoming release or in your case when #1484 is merged (we're still waiting for official release of 0.69.0 which is coming within days).

@zolbooo
Copy link
Author

zolbooo commented Jun 22, 2022

Great, thank you! I will use patch-package for now.

@zolbooo zolbooo closed this as completed Jun 22, 2022
@Mattesackboy
Copy link

Mattesackboy commented Jun 23, 2022

Here having the same issue, hoping to see a new version published with this fix soon now that React Native 0.69 is officially released! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missing repro This issue need minimum repro scenario Platform: iOS This issue is specific to iOS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants