Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump react-native version to 0.69.0 #1484

Merged
merged 45 commits into from
Jun 24, 2022
Merged

chore: bump react-native version to 0.69.0 #1484

merged 45 commits into from
Jun 24, 2022

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Jun 21, 2022 •
edited

Description

Bumped react-native version to 0.69.0-rc.6 in example / test applications (& also in /package.json).

Should also fix #1482

Changes

  • FabricTestExample iOS [x] Android [ ]
  • FabricExample iOS [x] Android [ ]
  • TestsExample iOS [x] Android [ ]
  • Added detection of RN minor version in RNScreens.podspec
  • Set appropriate compiler macro definition for react-native minor version
  • #if ... #else code related to these changes
  • Changed min. iOS version compilation target from 11.0 to 12.4

Test code and steps to reproduce

Build example applications and see that they work

Checklist

kkafar added 18 commits June 21, 2022 10:57
@kkafar
chore: TestsExample: set rn version to 0.69.0-rc.6 & react to 18.0.0
5d2b4ab 
see https://react-native-community.github.io/upgrade-helper/?from=0.68.2&to=0.69.0-rc.6
@kkafar
chore: TestsExample: run yarn install (update yarn.lock)
8d86531
@kkafar
chore: TestsExample: change target min. iOS version
29278a1 
see https://react-native-community.github.io/upgrade-helper/?from=0.68.2&to=0.69.0-rc.6

With lower version there are some dependency issues causing pod install
to fail (thats the visible efect, but there are some headers missing I
    guess)
@kkafar
chore: TestsExample: install pods
79d2205
@kkafar
chore: TestsExample: update pbxproj file
1e8d010
@kkafar
chore: FabricTestExample: bump react & react-native & other deps
db8323d 
versions
@kkafar
chore: FabricTestExample: update yarn.lock
bc49494
@kkafar
chore: FabricTestExample: change target min. iOS version to 12.4
e267c52
@kkafar
chore: bump react, react-native versions in main package.json
2337fd7
@kkafar
chore: set RNS_RN_VERSION_MINOR flag for all targets
2a0e423
@kkafar
fix: use mountingTransactionDidMount:withSurfaceTelemetry: instead of
dfdad7b 
mountingTransationWillMountWithMetadata: for react-native minor version
>= 69

See: facebook/react-native@91fc2c0
@kkafar
chore: reinstall pods in FabricTestExample
3ce7cbf
@kkafar
chore: reinstall pods in TestsExample
137852a
@kkafar
chore: bump react & react-native versions in FabricExample
554c290
@kkafar
chore: FabricExample: change target min. iOS version
a42cfe8
@kkafar
chore: FabricExample: reinstall pods
1898538
@kkafar
chore: bump gradlew wrapper version to 7.4.2 & kotlin plugin to 1.6.21
0867c99
@kkafar
fix: change ... TODO
cff8c13
@kkafar kkafar mentioned this pull request Jun 22, 2022
Closed
7 tasks
@kkafar kkafar changed the title chore: bump react-native version to 0.69.0-rc.6 chore: bump react-native version to 0.69.0 Jun 23, 2022
@tux2nicolae
Copy link

tux2nicolae commented Jun 23, 2022 •
edited

We have a problem building our application with 0.69.0 with the following error

Class 'kotlin.Unit' was compiled with an incompatible version of Kotlin. T binary version of its metadata is 1.6.0, expected version is 1.4.0.

I suppose this PR would fix that :)

Edit:
Actually, just noticed that the Android build from this PR is failing with the same error

@jenkijo
Copy link

jenkijo commented Jun 24, 2022

We have a problem building our application with 0.69.0 with the following error

Class 'kotlin.Unit' was compiled with an incompatible version of Kotlin. T binary version of its metadata is 1.6.0, expected version is 1.4.0.

I suppose this PR would fix that :)

Edit: Actually, just noticed that the Android build from this PR is failing with the same error

quick fix:

  • open file node_modules/react-native-screens/android/build.gradle
  • find line classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:${safeExtGet('kotlinVersion', '1.4.10')}"
  • change 1.4.10 to 1.6.21

@kkafar kkafar marked this pull request as ready for review June 24, 2022 11:11
@kkafar kkafar merged commit 166d60c into main Jun 24, 2022
@kkafar kkafar deleted the @kkafar/bump-rn-version branch June 24, 2022 11:17
This was referenced Jun 30, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoLewicki WoLewicki WoLewicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fabric build fails on iOS with nightly version
4 participants
@kkafar @tux2nicolae @jenkijo @WoLewicki