Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add test build Fabric workflows #1321

Merged
merged 5 commits into from Feb 16, 2022
Merged

feat: add test build Fabric workflows #1321

merged 5 commits into from Feb 16, 2022

Conversation

kacperkapusciak
Copy link
Member

Description

This PR adds two new workflow files - android-build-test-fabric.yml & ios-build-test-fabric.yml . These workflows test whether react-native-screens build without errors using Fabric architecture on both Android and iOS.

Checklist

  • Ensured that CI passes

Ubax
Ubax reviewed Feb 16, 2022
View reviewed changes
Copy link
Contributor

@Ubax Ubax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments. I think that this is a very good idea to test fabric. We just need to remember that it is affected by much more files then paper.

.github/workflows/android-build-test-fabric.yml Show resolved Hide resolved
.github/workflows/ios-build-test-fabric.yml Show resolved Hide resolved
kacperkapusciak and others added 2 commits February 16, 2022 09:30
@kacperkapusciak @Ubax
fix: add Fabric directories on Android
b140a60 
Co-authored-by: Jakub Tkacz <32908614+Ubax@users.noreply.github.com>
@kacperkapusciak @Ubax
fix: add Fabric directories on iOS
1e6b404 
Co-authored-by: Jakub Tkacz <32908614+Ubax@users.noreply.github.com>
@kacperkapusciak
Copy link
Member Author

Thanks @Ubax! 🎉 :shipit:

Ubax
Ubax approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@Ubax Ubax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

WoLewicki
WoLewicki approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please answer my comment, other than that LGTM!

.github/workflows/android-build-test-fabric.yml Outdated Show resolved Hide resolved
@kacperkapusciak kacperkapusciak merged commit 59e5ef2 into main Feb 16, 2022
@kacperkapusciak kacperkapusciak deleted the @kacperkapusciak/test-fabric-build-on-CI branch February 16, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ubax Ubax Ubax approved these changes

@WoLewicki WoLewicki WoLewicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kacperkapusciak @WoLewicki @Ubax