Remove additional config steps required when running Fabric version on Android #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Feb 16, 2022
tomekzaw
reviewed
Feb 16, 2022
tomekzaw
reviewed
Feb 16, 2022
kmagiera
changed the title
Ubax
reviewed
Feb 16, 2022
README-Fabric.md
Outdated
| 1. Add latest react-native-screens | ||
| 2. on iOS | ||
| - Install pods using `RCT_NEW_ARCH_ENABLED=1 pod install` (iOS only) | ||
| - Install pods using `RCT_NEW_ARCH_ENABLED=1 pod install` – this is a ste |
There was a problem hiding this comment.
Should it be this is the same as in Fabric app?
tomekzaw
reviewed
Feb 16, 2022
android/src/main/java/com/swmansion/rnscreens/RNScreensPackage.kt
Outdated
Show resolved
Hide resolved
Ubax
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the installation process on Android when using Fabric by removing the step when cpp dependency needs to be manually added to the main app's Android.mk file and also getting rid of the registry call that was ought to be added to ReactNativeHost implementation.
Changes
The following changes has been made:
Test code and steps to reproduce
Tested this in the following scenarios: