feat(Android): Add support for different Top App Bar styles #1874
Conversation
…sition of screens even better
tboba
force-pushed
the
@tboba/introduce-material3-finally-prettier-android-ui
branch
from
b4b31b9
to
cf32cbc
Compare
… CollapsingToolbarLayout
…`headerTopInsetEnabled` to false
…top, fix positioning of header items
…terial 3 into app
tboba
requested review from
WoLewicki and
kkafar
and removed request for
WoLewicki,
kacperkapusciak and
kkafar
| @@ -1,7 +1,7 @@ | |||
| package com.swmansion.rnscreens | |||
|
|
|||
| import android.content.Context | |||
| import androidx.appcompat.widget.Toolbar | |||
| import com.google.android.material.appbar.MaterialToolbar | |||
There was a problem hiding this comment.
We are sure it is safe to use on all configurations we support yes?
There was a problem hiding this comment.
I just ran the app on API 28 (with Material 3 and Material 2) and I can't observe any abnormalities, it works as usual 👍
| // On Material 3 the elevation is not visible on AppBarLayout. | ||
| // To prevent this behavior, we're setting outline shadow colors to black. | ||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.P) { | ||
| outlineAmbientShadowColor = Color.BLACK |
There was a problem hiding this comment.
Maybe it is something that could be controlled by the user?
There was a problem hiding this comment.
You mean the color of the elevation? I believe I've read somewhere the suggestion to add such modifier, so I believe we can do such thing! But let's maybe leave this idea for another PR.
android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt
Outdated
Show resolved
Hide resolved
| // Reattach the header, when the developer tries to change the header type | ||
| if (screenStackHeader?.loadedHeaderType != screen?.headerType) { | ||
| screenStackHeader?.updateHeaderType() | ||
| screenFragment?.removeToolbar() |
There was a problem hiding this comment.
That's because of updating the layoutParams of appBarLayout. Basically, when we're changing the type of appBar, its layout is being changed, resulting in wrong position of the views. For that reason we're removing all of its views (they will be added further in onUpdate) and setting references of toolbar and collapsingtoolbarlayout to null to ensure that we won't use old toolbars
|
This is very exciting! Awesome work! |
|
Currently, this PR is blocked by changes from facebook/react-native#44099 (we may skip requiring setting the prop |
|
That could make sense! We already set |
Description
Since the beginning of time...
Since the first version of react-native-screens...
There was a toolbar.
But toolbar have always been...
Small and non-expandable...
Nowadays...
times have changed.
This Pull Request introduces not 3, not 3.5, but 4 types of headers -
center-aligned,small,mediumandlargeheader types, where the last two of them can collapse.From now the toolbar will always be nested in
CollapsingToolbarLayout, but this shouldn't have an impact on the experience overall.Unfortunately, while having header type set to
mediumorlargetheheaderCenterproperty does not work for now.For the best experience of using new header types it is recommended to have Material 3 bundled into the application, while using new header types.
For more information about the header types, please visit official Material 3 documentation.
Changes
headerLeftandheaderRightprop)Screenshots / GIFs
Before
Screen.Recording.2023-09-01.at.17.22.13.mov
After
8mb.video-WMw-Zz1dZmWl.mp4
Test code and steps to reproduce
Use
Test1874attached to this branch to test the changes inTestsExample&FabricTestExample.Checklist