fix(Android): fix build deprecations #2116

alduzy · 2024-04-29T13:43:57Z

Description

This PR intents to fix some "Deprecated in Java" warnings when building on android. I decided not to suppress warnings manually when it is inescapable to avoid the warning.

Fixes #2018

Changes

replaced deprecated targetElavation with elevation
adjusted usage of porter duff color filter
calculating header top inset using recent method if android API >= 30 (the warning persists as the previous APIs still require deprecated method)
fixed guarded runnable deprecated warning
removed unused import

Screenshots / GIFs

Before

> Task :react-native-screens:compileDebugKotlin
'compileDebugJavaWithJavac' task (current target is 11) and 'compileDebugKotlin' task (current target is 17) jvm target compatibility should be set to the same Java version.
Consider using JVM toolchain: https://kotl.in/gradle/jvm/toolchain

w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/Screen.kt:83:22 'constructor GuardedRunnable(ReactContext!)' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt:65:27 'setter for targetElevation: Float' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt:128:27 'setter for targetElevation: Float' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt:86:34 'getter for systemWindowInsetTop: Int' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt:231:37 'setColorFilter(Int, PorterDuff.Mode): Unit' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt:63:22 'constructor GuardedRunnable(ReactContext!)' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt:108:22 'constructor GuardedRunnable(ReactContext!)' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt:135:47 'replaceSystemWindowInsets(Int, Int, Int, Int): WindowInsetsCompat' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt:136:51 'getter for systemWindowInsetLeft: Int' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt:138:51 'getter for systemWindowInsetRight: Int' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt:139:51 'getter for systemWindowInsetBottom: Int' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt:100:22 Parameter 'view' is never used
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt:100:43 Parameter 'placeholder' is never used
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/SearchBarView.kt:147:43 Parameter 'flag' is never used
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/HeaderHeightChangeEvent.kt:6:44 'RCTEventEmitter' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/paper/java/com/swmansion/rnscreens/FabricEnabledViewGroup.kt:11:42 Parameter 'width' is never used
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/paper/java/com/swmansion/rnscreens/FabricEnabledViewGroup.kt:11:54 Parameter 'height' is never used
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/paper/java/com/swmansion/rnscreens/FabricEnabledViewGroup.kt:11:67 Parameter 'headerHeight' is never used

After

> Task :react-native-screens:compileDebugKotlin
'compileDebugJavaWithJavac' task (current target is 11) and 'compileDebugKotlin' task (current target is 17) jvm target compatibility should be set to the same Java version.
Consider using JVM toolchain: https://kotl.in/gradle/jvm/toolchain

w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt:90:34 'getter for systemWindowInsetTop: Int' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt:135:47 'replaceSystemWindowInsets(Int, Int, Int, Int): WindowInsetsCompat' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt:136:51 'getter for systemWindowInsetLeft: Int' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt:138:51 'getter for systemWindowInsetRight: Int' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt:139:51 'getter for systemWindowInsetBottom: Int' is deprecated. Deprecated in Java
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt:100:22 Parameter 'view' is never used
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt:100:43 Parameter 'placeholder' is never used
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/SearchBarView.kt:147:43 Parameter 'flag' is never used
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/paper/java/com/swmansion/rnscreens/FabricEnabledViewGroup.kt:11:42 Parameter 'width' is never used
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/paper/java/com/swmansion/rnscreens/FabricEnabledViewGroup.kt:11:54 Parameter 'height' is never used
w: file:///Users/alexduzy/Projects/react-native-screens/Example/node_modules/react-native-screens/android/src/paper/java/com/swmansion/rnscreens/FabricEnabledViewGroup.kt:11:67 Parameter 'headerHeight' is never used

Test code and steps to reproduce

build android app to compare deprecation warnings quantity
run the example app and see wether the header shadow, backButton color and top inset behave correctly

Checklist

Ensured that CI passes

kkafar

Just a single question, rest of the changes seems perfectly fine 🟢

kkafar · 2024-04-29T14:52:55Z

android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt

@@ -62,7 +62,8 @@ class ScreenStackFragment : ScreenFragment, ScreenStackFragmentWrapper {

    override fun setToolbarShadowHidden(hidden: Boolean) {
        if (isToolbarShadowHidden != hidden) {
-            appBarLayout?.targetElevation = if (hidden) 0f else PixelUtil.toPixelFromDIP(4f)
+            appBarLayout?.elevation = if (hidden) 0f else PixelUtil.toPixelFromDIP(4f)
+            appBarLayout?.stateListAnimator = null


Why null here, instead of leaving default?

Without it the elevation is not set properly on initial render, I suppose the shadow is there by default so we have to reset it.

kkafar

I think we can merge 🟢 Thank you!

kkafar · 2024-05-06T07:19:16Z

android/src/main/java/com/swmansion/rnscreens/Screen.kt

@@ -80,7 +80,7 @@ class Screen(context: ReactContext?) : FabricEnabledViewGroup(context) {
    private fun updateScreenSizePaper(width: Int, height: Int) {
        val reactContext = context as ReactContext
        reactContext.runOnNativeModulesQueueThread(
-            object : GuardedRunnable(reactContext) {
+            object : GuardedRunnable(reactContext.exceptionHandler) {


I saw the warning you pasted in PR description, but I checked in source code & this is not deprecated 🤷🏻‍♂️

It's fine I guess

That's actually quite weird - according to the source code from Android Studio, GuardedRunnable with constructor with ReactContext parameter is deprecated though - I'm concerned why there's any difference here 🤔

I've found similar fix here: software-mansion/react-native-reanimated#1031

The reason why it is not deprecated right now is that since 0.73 this constructor has been de-deprecated 😄
I can see on 0.72 that @Deprecated is still there and has been removed since this commit.

kkafar · 2024-05-06T07:19:40Z

android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt

@@ -62,7 +62,8 @@ class ScreenStackFragment : ScreenFragment, ScreenStackFragmentWrapper {

    override fun setToolbarShadowHidden(hidden: Boolean) {
        if (isToolbarShadowHidden != hidden) {
-            appBarLayout?.targetElevation = if (hidden) 0f else PixelUtil.toPixelFromDIP(4f)
+            appBarLayout?.elevation = if (hidden) 0f else PixelUtil.toPixelFromDIP(4f)
+            appBarLayout?.stateListAnimator = null


tboba

LGTM! Just a small note from me 😄

tboba · 2024-05-06T07:54:37Z

android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt

@@ -82,7 +84,9 @@ class ScreenStackHeaderConfig(context: Context) : ViewGroup(context) {
        // we want to save the top inset before the status bar can be hidden, which would resolve in
        // inset being 0
        if (headerTopInset == null) {
-            headerTopInset = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M)
+            headerTopInset = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R)


Do you know if VERSION_CODES.R is already defined on lower supported Android versions?

I don't think it is, but it should be converted to a number during build time so it does not matter according to this thread: https://stackoverflow.com/questions/21874227/why-do-android-os-build-version-codes-work-on-older-platforms

Yeah, but where does the guarantee that this symbol is available in build time come from?

We have this guarantee only since August 2023.

I'm leaving link here for future git-blaming activities.

https://developer.android.com/google/play/requirements/target-sdk?hl=pl

Actually we don't have this guarantee, cause this link is about target. I guess we can reasonably safely assume that target & compile point to the same version 🤷🏻

tboba · 2024-05-06T11:46:45Z

Just one question about warnings @kkafar @alduzy - currently, some warnings about unused parameters are popping up while building screens. Do you think we should suppress them with annotation?

kkafar · 2024-05-06T12:05:05Z

I think they're popping because FabricEnabledViewGroup is used only as a stub while running on paper -> thus it is indeed unused but must be present. It is safe & ok to supress them with annotation

alduzy added 3 commits April 29, 2024 12:29

avoid using deprecated systemWindowInsetTop

1c8db08

replaced deprectaed targetElavation with elevation

4c36950

color filter deprecation fix

f1b34fe

alduzy requested a review from tboba April 29, 2024 13:44

alduzy changed the title ~~@alduzy/deprecated android fixes~~ fix(android) build deprecations fixes Apr 29, 2024

alduzy changed the title ~~fix(android) build deprecations fixes~~ fix(android): build deprecations fixes Apr 29, 2024

alduzy requested review from kacperkapusciak and kkafar April 29, 2024 14:22

removed unused deprecated import

b47f95f

kkafar reviewed Apr 29, 2024

View reviewed changes

alduzy requested a review from kkafar April 30, 2024 07:03

fixed guarded runnable deprecated warning

d6d68e9

kkafar approved these changes May 6, 2024

View reviewed changes

kkafar assigned alduzy and unassigned alduzy May 6, 2024

tboba changed the title ~~fix(android): build deprecations fixes~~ fix(Android): fix build deprecations May 6, 2024

tboba approved these changes May 6, 2024

View reviewed changes

alduzy requested a review from tboba May 6, 2024 08:16

alduzy merged commit 2a58846 into main May 6, 2024
4 checks passed

alduzy deleted the @alduzy/deprecated-android-fixes branch May 6, 2024 11:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Android): fix build deprecations #2116

fix(Android): fix build deprecations #2116

alduzy commented Apr 29, 2024 •

edited by tboba

kkafar left a comment

kkafar Apr 29, 2024

alduzy Apr 30, 2024 •

edited

kkafar May 6, 2024

kkafar left a comment

kkafar May 6, 2024

tboba May 6, 2024

alduzy May 6, 2024

tboba May 6, 2024

kkafar May 6, 2024

tboba left a comment

tboba May 6, 2024

alduzy May 6, 2024

kkafar May 6, 2024 •

edited

kkafar May 6, 2024 •

edited

kkafar May 6, 2024

tboba commented May 6, 2024

kkafar commented May 6, 2024

fix(Android): fix build deprecations #2116

fix(Android): fix build deprecations #2116

Conversation

alduzy commented Apr 29, 2024 • edited by tboba

Description

Changes

Screenshots / GIFs

Before

After

Test code and steps to reproduce

Checklist

kkafar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alduzy Apr 30, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kkafar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tboba left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kkafar May 6, 2024 • edited

Choose a reason for hiding this comment

kkafar May 6, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tboba commented May 6, 2024

kkafar commented May 6, 2024

alduzy commented Apr 29, 2024 •

edited by tboba

alduzy Apr 30, 2024 •

edited

kkafar May 6, 2024 •

edited

kkafar May 6, 2024 •

edited