feat: add types for header views and back button visibility prop #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
reviewed
Apr 12, 2020
| @@ -73,6 +79,14 @@ export default function HeaderConfig(props: Props) { | |||
| {headerRight !== undefined ? ( | |||
| <ScreenStackHeaderRightView>{headerRight()}</ScreenStackHeaderRightView> | |||
| ) : null} | |||
| {headerLeft !== undefined ? ( | |||
There was a problem hiding this comment.
The reason these were not exposed is because of inconsistent behaviour between Android and iOS. Can you check if it still happens?
WoLewicki
commented
Apr 14, 2020
chirag04
reviewed
May 6, 2020
| @@ -87,21 +91,29 @@ Whether the back button title should be visible or not. Defaults to `true`. Only | |||
|
|
|||
| Function which returns a React Element to display on the right side of the header. | |||
|
|
|||
| #### `headerLeft` | |||
|
|
|||
| Function which returns a React Element to display on the left side of the header. For now, on Android, using it will cause the title to also disappear. | |||
There was a problem hiding this comment.
@WoLewicki any recommendation on how to implement a custom back button with a title on android? happy to send. PR but needs some guidance on how to proceed
There was a problem hiding this comment.
https://github.com/software-mansion/react-native-screens/pull/457/files#diff-d63d0fa38279f7aa0d11c045d518a176L242 removes the title. You can comment that line and see what happens and work on it to be handled properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type definitions for
headerLeftandheaderCenterand an option allowing the custom left view to be rendered to the right of the back button requested in #445.