fix: add better shadow handling for newer apis #488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag04
reviewed
May 1, 2020
| StateListAnimator stateListAnimator = new StateListAnimator(); | ||
| stateListAnimator.addState(new int[0], ObjectAnimator.ofFloat(mAppBarLayout, "elevation",hidden ? 0 : TOOLBAR_ELEVATION)); | ||
| mAppBarLayout.setStateListAnimator(stateListAnimator); | ||
| } else if (mShadowHidden != hidden) { | ||
| mAppBarLayout.setTargetElevation(hidden ? 0 : TOOLBAR_ELEVATION); |
There was a problem hiding this comment.
is it even worth keeping this around?
chirag04
approved these changes
May 6, 2020
|
@WoLewicki would be great to ship this as well. thank you for the fix. 🙌 |
|
Closing due to #516. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
headerHideShadowis set to true on a screen, pushing another screen on top of it and then going back makes the shadow appear again. It looks like a problem with the usage of deprecated methodsetTargetElevation. This change fixes the problem on the newer APIs by using another method of changing the elevation. Should resolve #484.