fix: disable gestures in native stack on Android #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
approved these changes
May 6, 2020
chirag04
reviewed
May 6, 2020
| @@ -46,7 +46,7 @@ export default function NativeStackView({ | |||
| <Screen | |||
| key={route.key} | |||
| style={StyleSheet.absoluteFill} | |||
| gestureEnabled={gestureEnabled} | |||
| gestureEnabled={Platform.OS === 'android' ? false : gestureEnabled} | |||
There was a problem hiding this comment.
swipe gestures are common on android these days tho. there will be no way to have them on android with this change, yeah?
There was a problem hiding this comment.
gestureEnabled prop on Android handles dismissing screen by clicking hw back button and there are no swipe gestures supported by RNScreens on Android for now.
|
@WoLewicki Can you tell me why property |
|
It is there e.g. for people who would like to make their own implementation of JS side of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
ScreenStacks of native-stack navigators have the sameFragmentManager(because each of them is not under a differentScreencomponent), changing a screen in one of the stacks pops one screen in the other stack because of the https://github.com/software-mansion/react-native-screens/blob/master/android/src/main/java/com/swmansion/rnscreens/ScreenStack.java#L34 being called in bothScreenStacks by theFragmentManager. The workaround is to setgestureEnabledto false increateNativeStackNavigatoron Android since React-Navigation handles hw back button and setting it will make the https://github.com/software-mansion/react-native-screens/blob/master/android/src/main/java/com/swmansion/rnscreens/ScreenStack.java#L283 not to be called because the screen is not dismissable withoutgestureEnabledset totrue. Should fix #402. PR also fixes some indentations since the file was not indented properly.