Separate iOS specific code (Fix tvOS build) #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So you checked and these are all places where this should be applied so it compiles on tvOS? |
|
This way it compiles for tvOS, however, we're still in active initial development of the apps, and are on the lookout if any other modifications are necessary. Currently using these exact changes via |
WoLewicki
requested changes
Aug 14, 2020
Co-authored-by: Wojciech Lewicki <wojciech.lewicki@swmansion.com>
WoLewicki
reviewed
Aug 17, 2020
WoLewicki
reviewed
Aug 18, 2020
|
Thank you for your contribution! Looks like it is ready to be merged 🎉 |
|
Any ETA on a release build with these changes? |
|
Most probably next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #493 with changes applied and the original author @hufkens credited. @WoLewicki let me know if this would be ok to merge, as we would be using screens on tvOS as well, and currently need
patch-packagefor this. Additional flags by @gaborkajtar.