fix: add appContainer to modal screens #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmagiera
approved these changes
Sep 8, 2020
| @@ -106,7 +107,16 @@ export default function NativeStackView({ | |||
| }); | |||
| }}> | |||
| <HeaderConfig {...options} route={route} /> | |||
| <View style={viewStyles}>{renderScene()}</View> | |||
| {__DEV__ && | |||
There was a problem hiding this comment.
DEV checks can be stripped in build time but not when used like this. You can define a debug container in top level as follows and the use a simple if (DEV) statement:
let Container = View;
if (__DEV__) {
const DebugContainer = (props) => <AppContainer><View {...props}/></AppContainer>
Container = DebugContainer;
}
|
it might be worth opening a pr against react-native to expose this as a public api, what do you think @kmagiera? |
|
yes, I think it makes sense, react-native's modal uses that and I think there are some plans to move it out of the core repo. It'd be necessary to expose a way for modal to work outside of the core anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the implementation of
Modalinreact-native: https://github.com/facebook/react-native/blob/master/Libraries/Modal/Modal.js#L206, we attach each screen that is presented modally with anAppContainerthat has a listener forLogBoxandElementInspector. This allows for these elements to pop up over the modal screen. There will be 2ElementInspectorson the first screen due to 2AppContainercomponents rendered in it. If we added check for if theindex === 0, changing that index would unmount and remount screen content while calling e.g.navigation.reset(). Should resolve #268.