Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove useScreens and outdated code #705

Merged
merged 1 commit into from Nov 12, 2020
Merged

feat: remove useScreens and outdated code #705

merged 1 commit into from Nov 12, 2020

Conversation

WoLewicki
Copy link
Member

Description

Updated the code by removing the deprecated method and code checking for unsupported RN versions (we support RN >= 0.60). It is a breaking change due to the removal of useScreens.

Changes

Removed useScreens, code checking for UIManager[name] and Screen implementation for RN < 0.57.

Checklist

  • Updated TS types
  • Ensured that CI passes

kmagiera
kmagiera approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make sure to add informaction about useScreens being gone to release notes

@WoLewicki
Copy link
Member Author

I added it to the release draft with a note.

@WoLewicki WoLewicki merged commit f3bbd48 into master Nov 12, 2020
@WoLewicki WoLewicki deleted the @wolewicki/0.60-housecleaning branch November 12, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmagiera kmagiera kmagiera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WoLewicki @kmagiera