feat: update READMES and add missing props #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
commented
Nov 30, 2020
| @@ -50,7 +50,7 @@ String that applies `rtl` or `ltr` form to the stack. On Android, you have to ad | |||
|
|
|||
| Whether you can use gestures to dismiss this screen. Defaults to `true`, | |||
|
|
|||
| Gestures are only supported on iOS. They can be disabled only when `stackPresentation` is `push`. | |||
| Gestures are only supported on iOS. | |||
There was a problem hiding this comment.
I changed this line, since, from iOS 13, this prop will also disable the possibility to dismiss a modal with a swipe gesture.
kmagiera
approved these changes
Dec 22, 2020
WoLewicki
force-pushed
the
@wolewicki/add-missing-props
branch
from
a4dfa86
to
076775e
Compare
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added missing props to
native-stackand updated READMEs.Changes
Updated all
READMEs to mirror the available options. IncreateNativeStackNavigator.jschanged the option forlargeTitleBackgroundColorto be the same as with the newernative-stackand added missing prop.Checklist