Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace deprecated API #768

Merged
merged 2 commits into from Jan 26, 2021

Conversation

sunzhongliangde
Copy link
Contributor

@sunzhongliangde sunzhongliangde commented Jan 7, 2021

@sunzhongliangde sunzhongliangde changed the title refactor: replace deprecate API refactor: replace deprecated API Jan 7, 2021
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I think we can skip the part with checking if respondsToSelector and just change the code to usage of moduleForClass.

@sunzhongliangde
Copy link
Contributor Author

sunzhongliangde commented Jan 25, 2021

Thanks for your contribution! I think we can skip the part with checking if respondsToSelector and just change the code to usage of moduleForClass.

However, I see the configuration of the package.json is like this
"react": "*", "react-native": "*"
If the user uses a lower react-native version, then this deprecated method will not be marked, so the safe way is add this condition to judge

@WoLewicki
Copy link
Member

react-native-screens support RN versions since 0.60 (https://github.com/software-mansion/react-native-screens#supported-react-native-version), and it is available there for sure.

@sunzhongliangde
Copy link
Contributor Author

react-native-screens support RN versions since 0.60 (https://github.com/software-mansion/react-native-screens#supported-react-native-version), and it is available there for sure.

Thanks, I removed it.

@WoLewicki WoLewicki merged commit 8e2829c into software-mansion:master Jan 26, 2021
WoLewicki pushed a commit that referenced this pull request Jan 28, 2021
replace deprecate bridge.imageloader API, use moduleForClass:

Co-authored-by: sunzhongliang <sunzhongliang@innotechx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants