Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore the proper type for NavigationConfig #810

Merged
merged 1 commit into from Feb 11, 2021
Merged

fix: restore the proper type for NavigationConfig #810

merged 1 commit into from Feb 11, 2021

Conversation

WoLewicki
Copy link
Member

Description

Suggested by @satya164 revert of NativeStackNavigationConfig to an empty object. It makes the native-stack Navigator accept only screenOptions, just how it is supposed to do. Should fix #809.

Changes

Changed native-stack types.tsx to properly show props for navigator.

Test code and steps to reproduce

Pass props other than screenOptions to native-stack's Navigator component.

Checklist

  • Updated TS types
  • Ensured that CI passes

@WoLewicki WoLewicki mentioned this pull request Feb 11, 2021
Closed
@WoLewicki WoLewicki merged commit b00a488 into master Feb 11, 2021
@WoLewicki WoLewicki deleted the @wolewicki/restore-proper-config branch February 11, 2021 13:52
This was referenced Mar 15, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satya164 satya164 satya164 approved these changes

@sbalay sbalay sbalay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ts] v5 native stack does not throw error when using unknown props on it
3 participants
@WoLewicki @satya164 @sbalay