Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rtl transition without header on iOS #831

Merged
merged 1 commit into from Feb 25, 2021
Merged

fix: rtl transition without header on iOS #831

merged 1 commit into from Feb 25, 2021

Conversation

WoLewicki
Copy link
Member

Description

Moved check for rtl to before the return option with header not shown to be able to apply rtl transition between screens.

Test code and steps to reproduce

Test831.tsx in TestsExample project.

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

@WoLewicki WoLewicki merged commit 5f31cd8 into master Feb 25, 2021
@WoLewicki WoLewicki deleted the @wolewicki/rtl-without-header branch February 25, 2021 10:22
This was referenced Mar 15, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kacperkapusciak kacperkapusciak kacperkapusciak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WoLewicki @kacperkapusciak