feat: make enabled take precendce over ENABLE_SCREENS #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperkapusciak
deleted the
@wolewicki/make-enabled-higher-prio-than-enableScreens
branch
This was referenced May 21, 2021
Closed
Closed
This was referenced Jun 6, 2021
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the logic to make the
enabledprop set totrueresult in using native code even ifENABLE_SCREENSis set tofalse.Changes
Changed
index.native.tsx.Test code and steps to reproduce
Don't call
enableScreens()in your app and don't passfalsetodetachInactiveScreensin your navigator and it will resolve in nativereact-native-screenscomponents being used.Checklist