Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly handle first screen on stack #882

Merged

Conversation

kacperkapusciak
Copy link
Member

Description

When a screen is added to an empty stack it shouldn't have any animation.
The issue is described in detail in #881.
Fixes #881.

Changes

Changed the default value of stackAnimation to null in ScreenStack.java and handle it accordingly.

Test code and steps to reproduce

Test881.tsx in TestsExample project.

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

@kacperkapusciak kacperkapusciak merged commit 56b2012 into master Apr 15, 2021
@kacperkapusciak kacperkapusciak deleted the @kacperkapusciak/properly-handle-first-screen-on-stack branch April 15, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.1.0 Introduced animations on android for Bottom Tab navigation transitions
1 participant