fix: no events when swipe cancelled #951
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the swipe to go back is cancelled, all lifecycle events are called on both transitioning screens and we don't want them to be sent to JS. In the future, we can send e.g.
swipeCancelled
event in such case if it is requested by users.Changes
Added logic catching the case of cancelled swipe and not calling notification methods then.
Test code and steps to reproduce
Test593.tsx
inTestsExample
project.Checklist