fix: make sure we only call onDetachedFromWindow once #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacperkapusciak
approved these changes
Jun 17, 2021
Strate
added a commit
to chatium/react-native-screens
that referenced
this pull request
Nov 2, 2021
Meninblack007
pushed a commit
to myntra/react-native-screens
that referenced
this pull request
Nov 2, 2022
…on#985) Suggested by @kmagiera change to ScreenContainer.java, altering software-mansion#477, switching removeAllViews(); to removeViewAt(i); in order to fix the case of calling onDetachedFromWindow multiple times in the child Screens, which can be seen in Test913.tsx. This behaviour occurs due to the logic of removeAllViews method, which does not check if the child views are not already detached when the method is called, whereas the check is present in removeViewAt method (see https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/view/ViewGroup.java#5559 which is not present in https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/view/ViewGroup.java#5771).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Suggested by @kmagiera change to
ScreenContainer.java, altering #477, switchingremoveAllViews();toremoveViewAt(i);in order to fix the case of callingonDetachedFromWindowmultiple times in the childScreens, which can be seen inTest913.tsx. This behaviors occurs due to the logic ofremoveAllViewsmethod, which does not check if the child views are not already detached when the method is called, whereas the check is present inremoveViewAtmethod (see https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/view/ViewGroup.java#5559 which is not present in https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/view/ViewGroup.java#5771).Test code and steps to reproduce
Test913.tsxinTestsExampleproject.Checklist