Skip to content

Commit

Permalink
fix: error for transform on web (#2139)
Browse files Browse the repository at this point in the history
Setting transform prop of svg component as undefined in web causes the error, so we set it only if the parsed value is not undefined.
  • Loading branch information
WoLewicki committed Sep 20, 2023
1 parent 23d65b9 commit 5f3bd0d
Showing 1 changed file with 13 additions and 3 deletions.
16 changes: 13 additions & 3 deletions src/ReactNativeSVG.web.ts
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,19 @@ const prepare = <T extends BaseProps>(
clean['transform-origin'] = `${originX || 0} ${originY || 0}`;
}

clean.transform = parseTransformProp(transform, props);
clean.gradientTransform = parseTransformProp(gradientTransform);
clean.patternTransform = parseTransformProp(patternTransform);
// we do it like this because setting transform as undefined causes error in web
const parsedTransform = parseTransformProp(transform, props);
if (parsedTransform) {
clean.transform = parsedTransform;
}
const parsedGradientTransform = parseTransformProp(gradientTransform);
if (parsedGradientTransform) {
clean.gradientTransform = parsedGradientTransform;
}
const parsedPatternTransform = parseTransformProp(patternTransform);
if (parsedPatternTransform) {
clean.patternTransform = parsedPatternTransform;
}

clean.ref = (el: SVGElement | null) => {
self.elementRef.current = el;
Expand Down

0 comments on commit 5f3bd0d

Please sign in to comment.