[andriod] invalidate SvgView when view hierarchy changes

software-mansion · Dec 7, 2018 · b896714 · b896714
1 parent 69e9fcd
commit b896714
Showing 1 changed file with 29 additions and 5 deletions.
diff --git a/android/src/main/java/com/horcrux/svg/RenderableViewManager.java b/android/src/main/java/com/horcrux/svg/RenderableViewManager.java
@@ -11,6 +11,7 @@
 
 import android.graphics.Matrix;
 import android.view.View;
+import android.view.ViewGroup;
 
 import com.facebook.infer.annotation.Assertions;
 import com.facebook.react.bridge.Dynamic;
@@ -1012,6 +1013,33 @@ public void setName(VirtualView node, String name) {
         node.setName(name);
     }
 
+    private void invalidateSvgView(VirtualView node) {
+        SvgView view = node.getSvgView();
+        if (view!= null) {
+            view.invalidate();
+        }
+    }
+
+    @Override
+    protected void addEventEmitters(ThemedReactContext reactContext, VirtualView view) {
+        super.addEventEmitters(reactContext, view);
+        view.setOnHierarchyChangeListener(new ViewGroup.OnHierarchyChangeListener() {
+            @Override
+            public void onChildViewAdded(View view, View view1) {
+                if (view instanceof VirtualView) {
+                    invalidateSvgView((VirtualView) view);
+                }
+            }
+
+            @Override
+            public void onChildViewRemoved(View view, View view1) {
+                if (view instanceof VirtualView) {
+                    invalidateSvgView((VirtualView) view);
+                }
+            }
+        });
+    }
+
     /**
      * Callback that will be triggered after all properties are updated in current update transaction
      * (all @ReactProp handlers for properties updated in current transaction have been called). If
@@ -1021,11 +1049,7 @@ public void setName(VirtualView node, String name) {
     @Override
     protected void onAfterUpdateTransaction(VirtualView node) {
         super.onAfterUpdateTransaction(node);
-        SvgView view = node.getSvgView();
-        if (view == null) {
-            return;
-        }
-        view.invalidate();
+        invalidateSvgView(node);
     }
 
     @Override