New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] add onLoad to SvgUri and fix typings for LocalSvg #1449
Conversation
lgtm |
1 similar comment
lgtm |
Can we get this merged please? @msand |
gg |
can we get this merged? |
Still no merge? Seems like it's good to go. |
dead repo |
Can we please merge this?? |
repo is dead so create your own or patch-package |
@harveyconnor could you rebase to the newest |
I made this PR a very long time ago... |
Yeah, I see 😅 Will you be able to do that or should someone make a new one with those changes? |
I currently don't have time to do that unfortunately. |
Since #1817 has been merged, I will close this PR. Thanks for your contribution! |
Summary
Test Plan
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
What's required for testing (prerequisites)?
Nothing, everything should work as is.
What are the steps to reproduce (after prerequisites)?
Import the LocalSvg using TypeScript or apply a onLoad attribute prop to the SvgUri.
Compatibility
Checklist
README.md
__tests__
folder