Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add onLoad to SvgUri and fix typings for LocalSvg #1449

Closed
wants to merge 6 commits into from

Conversation

harveyconnor
Copy link

Summary

  • Added a simple onLoad prop to the SvgUri
    • Allows users to show a loading state in their implementation whilst fetching the svg from the server.
  • Added typings for LocalSvg class in the index.d.ts
    • Resolves issues when trying to import LocalSvg via TypeScript

Test Plan

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

What's required for testing (prerequisites)?

Nothing, everything should work as is.

What are the steps to reproduce (after prerequisites)?

Import the LocalSvg using TypeScript or apply a onLoad attribute prop to the SvgUri.

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

@huming2207
Copy link

lgtm

1 similar comment
@dannyifang
Copy link

lgtm

@harveyconnor
Copy link
Author

Can we get this merged please? @msand

@huming2207
Copy link

Can we get this merged please? @msand

gg

@harveyconnor
Copy link
Author

can we get this merged?

@nickmcmillan
Copy link

Still no merge? Seems like it's good to go.

@harveyconnor
Copy link
Author

dead repo

@ayu-webmaster
Copy link

@magicismight

@lucascorrea97
Copy link

Can we please merge this??

@harveyconnor
Copy link
Author

repo is dead so create your own or patch-package

@WoLewicki
Copy link
Member

@harveyconnor could you rebase to the newest develop branch, remove the changes not concerning this PR, and add a test example to TestsExample project where we could test this change? It would greatly shorten the time the maintainers would need to spend in order to get this merged. Thank you in advance 🙏

@harveyconnor
Copy link
Author

@harveyconnor could you rebase to the newest develop branch, remove the changes not concerning this PR, and add a test example to TestsExample project where we could test this change? It would greatly shorten the time the maintainers would need to spend in order to get this merged. Thank you in advance 🙏

I made this PR a very long time ago...

@WoLewicki
Copy link
Member

Yeah, I see 😅 Will you be able to do that or should someone make a new one with those changes?

@harveyconnor
Copy link
Author

I currently don't have time to do that unfortunately.

@WoLewicki WoLewicki changed the base branch from develop to main July 25, 2022 10:30
@WoLewicki
Copy link
Member

Since #1817 has been merged, I will close this PR. Thanks for your contribution!

@WoLewicki WoLewicki closed this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants