Xcode 12 compatibility fix #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone merge this in? |
This was referenced Jun 28, 2021
4 tasks
91 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Latest Xcode 12 fails to build while without a module to depend on
React-Coredirectly hence this change is necessary for all native modules on iOS. For more details please check: facebook/react-native#29633Recently, all React Native modules made this necessary change.
React Native SVG is one of the latest that didn't fix this.
Test Plan
Use this branch to install with an app running on Xcode 12.
What's required for testing (prerequisites)?
Xcode 12 & a recent version of React Native (like 0.64)
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.md(no need)__tests__folder (no need)