Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing onLayout prop typings #1607

Closed
wants to merge 3 commits into from
Closed

Add missing onLayout prop typings #1607

wants to merge 3 commits into from

Conversation

sinxwal
Copy link
Contributor

@sinxwal sinxwal commented Jun 24, 2021

Summary

onLayout prop typings are missing. This PR simply adds missing onLayout prop to svg nodes.

Compatibility

OS Implemented
iOS ✅
Android ✅

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

@sinxwal sinxwal mentioned this pull request Jun 24, 2021
Closed
guiccbr
guiccbr reviewed Nov 30, 2021
View reviewed changes
src/index.d.ts Outdated Show resolved Hide resolved
@sinxwal
Copy link
Contributor Author

sinxwal commented Dec 1, 2021

@guiccbr ready for merge

@guiccbr
Copy link

guiccbr commented Dec 2, 2021

@guiccbr ready for merge

I can't merge. I'm not a maintainer : (

@WoLewicki WoLewicki changed the base branch from develop to main July 26, 2022 13:41
@WoLewicki WoLewicki mentioned this pull request Jul 26, 2022
Merged
@WoLewicki
Copy link
Member

Since #1815, I will close this PR. Thanks for your contribution! 🎉

@WoLewicki WoLewicki closed this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guiccbr guiccbr guiccbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sinxwal @guiccbr @WoLewicki