feat: add Fabric on iOS without ComponentViews #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kkafar
reviewed
Aug 8, 2022
| source 'https://rubygems.org' | ||
|
|
||
| # You may use http://rbenv.org/ or https://rvm.io/ to install and use this version | ||
| ruby '2.7.4' |
There was a problem hiding this comment.
Ruby was bumped up to '2.7.5' with React Native 0.69.0 however I doubt it would cause any problems.
Comment on lines
+31
to
+32
| libfolly_futures \ | ||
| libfolly_json \ |
There was a problem hiding this comment.
This also was changed in recent React Native versions.
Suggested change
| libfolly_futures \ | |
| libfolly_json \ | |
| libfolly_runtime \ |
WoLewicki
added a commit
that referenced
this pull request
Aug 12, 2022
Most of Android changes for Fabric and bump of FabricExample to RN 0.69.2. iOS and JS changes are available in #1821. The most notable change on Android is adding methods to components that accept String values of each NumberProp instead of Dynamic. Another change is changed structure of RenderableViewManager.java since we needed to abstract methods that belong only to components inheriting from VirtualView in order to be able to properly override them in their children.
aaron1234567890123
added a commit
to aaron1234567890123/react-native-svg
that referenced
this pull request
Jun 8, 2024
Version of software-mansion#1754 without usage of ComponentViews. It seems like a more proper way, but introduces the necessity of clearing whole state of each component on recycling for it not to be used when view is recycled. Still known problems: We stringify props of type NumberProp since codegen only accepts props of a single type. It is the fastest way of dealing with it, but maybe there could be a better way to handle it. Image resolving should be probably handled the same as in RN core SvgView needs to set opaque = NO so it is does not have black background (it comes from the fact that RCTViewComponentView overrides backgroundColor setter which in turn somehow messes with the view being opaque). All other svg components do it already so maybe it is not such an issue. transform prop won't work when set natively since it is not parsed in Fabric
aaron1234567890123
added a commit
to aaron1234567890123/react-native-svg
that referenced
this pull request
Jun 8, 2024
Version of software-mansion#1754 without usage of ComponentViews. It seems like a more proper way, but introduces the necessity of clearing whole state of each component on recycling for it not to be used when view is recycled. Still known problems: We stringify props of type NumberProp since codegen only accepts props of a single type. It is the fastest way of dealing with it, but maybe there could be a better way to handle it. Image resolving should be probably handled the same as in RN core SvgView needs to set opaque = NO so it is does not have black background (it comes from the fact that RCTViewComponentView overrides backgroundColor setter which in turn somehow messes with the view being opaque). All other svg components do it already so maybe it is not such an issue. transform prop won't work when set natively since it is not parsed in Fabric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Version of #1754 without usage of
ComponentViews. It seems like a more proper way, but introduces the necessity of clearing whole state of each component on recycling for it not to be used when view is recycled.Still known problems:
NumberPropsince codegen only accepts props of a single type. It is the fastest way of dealing with it, but maybe there could be a better way to handle it.opaque = NOso it is does not have black background (it comes from the fact thatRCTViewComponentViewoverridesbackgroundColorsetter which in turn somehow messes with the view beingopaque). All other svg components do it already so maybe it is not such an issue.transformprop won't work when set natively since it is not parsed in Fabric