-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance optimisations and support for nesting Svg and View inside Svg. #596
Conversation
👀 |
@msand First of, thanks for the work, really appreciated! Now, I've been playing around with these changes and noticed that it's possible to add Text into the nested View on iOs and that it works as expected but that I can't get it to show on Android, so my question is then, is this intentional or a bug of sorts? Or are you actually not supposed to add any elements inside the View at all? |
@AntonNixonNixon this is a limitation of android on react native core I wanna to come up with a lint that detects this case, so we can avoid this bugs on android |
@AntonNixonNixon @sibelius I have an attempt for supporting nested native text views on android now, can you test it and see if it behaves according to your expectations? #658 |
I believe @sibelius is thinking of nesting native text inside images, which isn't supported on android. Native text and views inside svg are possible, we just need to define how it should work. The current implementation probably doesn't even make sense, the CTM should probably propagate from svg to rn views. |
@msand is the release with this PR done because I am still facing issues setting width to 100% |
@msand can you please provide an example of nesting svg? I not sure how to use it and I can not find any proper example on internet. every nested svg I had create gives me |
No description provided.