Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimisations and support for nesting Svg and View inside Svg. #596

Merged
merged 10 commits into from
Mar 18, 2018

Conversation

msand
Copy link
Collaborator

@msand msand commented Feb 6, 2018

No description provided.

@msand msand changed the title First attempt at nested svg support. Performance optimisations and support for nesting Svg and View inside Svg. Feb 23, 2018
@msand msand self-assigned this Feb 23, 2018
@koxen
Copy link

koxen commented Mar 6, 2018

👀

@msand msand merged commit 8ff052c into software-mansion:master Mar 18, 2018
@AntonNixonNixon
Copy link

@msand First of, thanks for the work, really appreciated! Now, I've been playing around with these changes and noticed that it's possible to add Text into the nested View on iOs and that it works as expected but that I can't get it to show on Android, so my question is then, is this intentional or a bug of sorts? Or are you actually not supposed to add any elements inside the View at all?

@sibelius
Copy link

sibelius commented Apr 9, 2018

@AntonNixonNixon this is a limitation of android on react native core

I wanna to come up with a lint that detects this case, so we can avoid this bugs on android

@msand
Copy link
Collaborator Author

msand commented Apr 21, 2018

@AntonNixonNixon @sibelius I have an attempt for supporting nested native text views on android now, can you test it and see if it behaves according to your expectations? #658

@msand
Copy link
Collaborator Author

msand commented Apr 22, 2018

I believe @sibelius is thinking of nesting native text inside images, which isn't supported on android. Native text and views inside svg are possible, we just need to define how it should work. The current implementation probably doesn't even make sense, the CTM should probably propagate from svg to rn views.

@vivek12345
Copy link

@msand is the release with this PR done because I am still facing issues setting width to 100%

@SaeedZhiany
Copy link
Contributor

@msand can you please provide an example of nesting svg? I not sure how to use it and I can not find any proper example on internet. every nested svg I had create gives me unknown bitmap configuration error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants