Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for human readable message in MetadataCommand #1098

Merged
merged 11 commits into from
Jan 31, 2024
Merged

Support for human readable message in MetadataCommand #1098

merged 11 commits into from
Jan 31, 2024

Conversation

Draggu
Copy link
Contributor

@Draggu Draggu commented Jan 29, 2024

Added support for human readable message in MetadataCommand by removing --json flag from MetadataCommand and adding inherit_stdout() method.

maciektr
maciektr reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💪
Please find some comments attached below.

.tool-versions Outdated Show resolved Hide resolved
scarb-metadata/src/command/internal_command.rs Outdated Show resolved Hide resolved
scarb-metadata/src/version_pin.rs Outdated Show resolved Hide resolved
scarb-metadata/src/command/metadata_command.rs Outdated Show resolved Hide resolved
scarb-metadata/src/command/metadata_command.rs Outdated Show resolved Hide resolved
maciektr
maciektr reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Last one thing to consider before we can merge it.

scarb-metadata/src/command/metadata_command.rs Outdated Show resolved Hide resolved
scarb-metadata/src/command/metadata_command.rs Outdated Show resolved Hide resolved
maciektr
maciektr approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

mkaput
mkaput approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. I see that this code does buffer entire stdout while it shouldn't, but that's something Scarb team can built on top of this code.

@maciektr maciektr added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit 3a80725 Jan 31, 2024
20 checks passed
@maciektr maciektr deleted the use-regular-output branch January 31, 2024 09:30
@maciektr maciektr mentioned this pull request Jan 31, 2024
Open
@Draggu Draggu mentioned this pull request Jan 31, 2024
Merged
5 tasks
@chenrui333 chenrui333 mentioned this pull request Feb 1, 2024
Merged
github-merge-queue bot pushed a commit to foundry-rs/starknet-foundry that referenced this pull request Feb 6, 2024
@Draggu
Use scarb metadata error pretty print (#1636)
ba402c3 
<!-- Reference any GitHub issues resolved by this PR -->

Closes #1509

## Introduced changes

<!-- A brief description of the changes -->

- Use `MetadataCommand` output, see:
software-mansion/scarb#1098

## Checklist

<!-- Make sure all of these are complete -->

- [x] Linked relevant issue
- [x] Updated relevant documentation
- [x] Added relevant tests
- [x] Performed self-review of the code
- [x] Added changes to `CHANGELOG.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

@maciektr maciektr maciektr approved these changes

@tomek0123456789 tomek0123456789 Awaiting requested review from tomek0123456789

@szymmis szymmis Awaiting requested review from szymmis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Draggu @mkaput @maciektr