New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support signed declare transaction #149
Conversation
Thing to consider: with current supported version of the RPC spec, it's impossible to send signed declare transactions. Starknet-jvm will first have to be updated to support RPC 0.2.0 for these to be able to work. |
Codecov ReportBase: 66.42% // Head: 68.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 66.42% 68.22% +1.80%
==========================================
Files 52 52
Lines 1382 1432 +50
Branches 83 85 +2
==========================================
+ Hits 918 977 +59
+ Misses 440 430 -10
- Partials 24 25 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/Transaction.kt
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/TransactionPayload.kt
Outdated
Show resolved
Hide resolved
af31e69
to
9f778d5
Compare
37ab7dc
to
26b53ea
Compare
Note that the Rpc provider doesn't support sending signed Declare txs. I've added an error for that so it doesn't fail silently/is ignored. This will have to be addressed once rpc 0.2.1 is supported, shouldn't require any changes to the Account itself however. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Describe your changes
This PR adds support for signing declare transactions and sending them.
Linked issues
Closes #145
Breaking changes