Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running synchronous action on Future coming from OkHttp #168

Merged
merged 1 commit into from Oct 14, 2022

Conversation

Solpatium
Copy link
Contributor

Currently thenApply causes deserialize to run synchronously after future is resolved in OkHttp thread.

@codecov-commenter
Copy link

Codecov Report

Base: 63.53% // Head: 63.53% // No change to project coverage 👍

Coverage data is based on head (6c7a2e0) compared to base (e4e4a44).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   63.53%   63.53%           
=======================================
  Files          49       49           
  Lines        1226     1226           
  Branches       79       79           
=======================================
  Hits          779      779           
+ Misses        425      423    -2     
- Partials       22       24    +2     
Impacted Files Coverage Δ
...com/swmansion/starknet/service/http/HttpRequest.kt 85.71% <0.00%> (ø)
...tlin/com/swmansion/starknet/crypto/NativeLoader.kt 29.03% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Solpatium Solpatium merged commit 16b06f8 into main Oct 14, 2022
@DelevoXDG DelevoXDG deleted the fix/synchronous-map-in-okttp-pool branch February 5, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants