Add L1_HANDLER transaction support for GatewayProvider
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solpatium
suggested changes
Nov 4, 2022
lib/src/main/kotlin/com/swmansion/starknet/data/types/transactions/Transaction.kt
Outdated
Show resolved
Hide resolved
lib/src/main/kotlin/com/swmansion/starknet/provider/gateway/GatewayProvider.kt
Show resolved
Hide resolved
Codecov ReportBase: 63.53% // Head: 62.67% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
==========================================
- Coverage 63.53% 62.67% -0.87%
==========================================
Files 49 49
Lines 1226 1243 +17
Branches 79 81 +2
==========================================
Hits 779 779
- Misses 423 440 +17
Partials 24 24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Solpatium
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds L1HandlerTransaction dataclass as well as suport for parsing these transactions to GatewayProvider.
It also inlines
transactionTypeToNamefunction.Tests have been mocked until we resolve how to test L1<>L2 messaging with devnet (this is also being investigated by starknet.py team).
This PR however doesn't add support for L1HandlerTransactions to JsonRpcProvider as it is blocked by #146
Linked issues
Closes #167
Breaking changes