Default value for blockTag argument in provider methods #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cptartur
reviewed
Aug 25, 2022
cptartur
reviewed
Sep 26, 2022
| @@ -43,14 +43,25 @@ interface Provider { | |||
| */ | |||
| fun callContract(call: Call, blockNumber: Int): Request<List<Felt>> | |||
|
|
|||
| /** | |||
| * Calls a contract deployed on StarkNet. | |||
There was a problem hiding this comment.
Perhaps these overloaded method should have a info in their docs that they use default block tag LATEST.
cptartur
approved these changes
Sep 26, 2022
Codecov ReportBase: 62.50% // Head: 62.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 62.50% 62.40% -0.10%
==========================================
Files 45 46 +1
Lines 1176 1181 +5
Branches 68 68
==========================================
+ Hits 735 737 +2
- Misses 422 425 +3
Partials 19 19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added default values to blockTag params in provider methods, so these methods can be called without specifying blockId.
Swapped order of arguments in getClassAt method, to align it with other Provider methods (potential breaking change)