Add Account.deploy_account_v3 static method
#1265
Conversation
| StarknetChainId.GOERLI, | ||
| StarknetChainId.MAINNET, | ||
| ): | ||
| if chain in StarknetChainId: | ||
| balance = await account.get_balance() | ||
| if balance < deploy_account_tx.max_fee: |
There was a problem hiding this comment.
I am not sure how to implement a similar check for the V3 transaction now. I'm guessing eventually we'd need to pull the balance from the STRK contract and an exchange rate to WEI?
Let me know if I am missing something here. Generally I think it is not crucial, but definitely nice to have.
There was a problem hiding this comment.
Good question. I suppose it could depend on fee DA mode as well, but I'm not 100% sure. Let's open an issue to investigate this, we might need to ask SW as well.
There was a problem hiding this comment.
This is not crucial since tx will be rejected with a descriptive enough error message anyway
I'm guessing eventually we'd need to pull the balance from the STRK contract and an exchange rate to WEI?
It should probably be done the same way, except we'll have to pass STRK token address to get_balance. I don't really understand why'd you want to convert to WEI though?
There was a problem hiding this comment.
You're absolutely right, there is no need for conversion. I thought that L1_GAS in the resource bounds is specified in WEI, even though V3 transaction costs are paid in FRI, which is not the case. Apologies for the confusion.
We can indeed check it the same way as for V1, but with the STRK contract. On the other hand, as @DelevoXDG said, it is not crucial, since it will throw an error anyway. @THenry14 Wdyt?
There was a problem hiding this comment.
Agreed, let's update #1266 with the findings and do necessary changes under that issue at some later date
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1265 +/- ##
============================================
Coverage 98.00% 98.00%
============================================
Files 89 89
Lines 4513 4522 +9
============================================
+ Hits 4423 4432 +9
Misses 90 90
|
| StarknetChainId.GOERLI, | ||
| StarknetChainId.MAINNET, | ||
| ): | ||
| if chain in StarknetChainId: | ||
| balance = await account.get_balance() | ||
| if balance < deploy_account_tx.max_fee: |
There was a problem hiding this comment.
Good question. I suppose it could depend on fee DA mode as well, but I'm not 100% sure. Let's open an issue to investigate this, we might need to ask SW as well.
| StarknetChainId.GOERLI, | ||
| StarknetChainId.MAINNET, | ||
| ): | ||
| if chain in StarknetChainId: | ||
| balance = await account.get_balance() | ||
| if balance < deploy_account_tx.max_fee: |
There was a problem hiding this comment.
This is not crucial since tx will be rejected with a descriptive enough error message anyway
I'm guessing eventually we'd need to pull the balance from the STRK contract and an exchange rate to WEI?
It should probably be done the same way, except we'll have to pass STRK token address to get_balance. I don't really understand why'd you want to convert to WEI though?
ddoktorski
deleted the
ddoktorski/1235-rpc-0.6.0-Account-deploy-account
branch
Related to #1235 and #1262
Introduced changes
Account.deploy_account_v3()deploy_account->deploy_account_v1execute->execute_v1Please note that documentation update will be done in a separate PR.