Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify types in TypedData in line with SNIP-12 #1369

Merged
merged 129 commits into from
Jun 29, 2024

Conversation

franciszekjob
Copy link
Contributor

@franciszekjob franciszekjob commented Jun 23, 2024

Relates #1353

Introduced changes

Ensure type verification logic in line with guidelines. Restrictions related to enum basic type will be added separately in next PRs.

  • Disallow empty names, names with *, dangling types
  • Require domain type to be present in types
  • Add tests for types redefinition, missing domain type, dangling type, missing dependency

  • This PR contains breaking changes

franciszekjob and others added 30 commits June 14, 2024 16:03
franciszekjob and others added 5 commits June 26, 2024 15:00
Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
Co-authored-by: ddoktorski <45050160+ddoktorski@users.noreply.github.com>
starknet_py/utils/typed_data.py Outdated Show resolved Hide resolved
starknet_py/utils/typed_data.py Outdated Show resolved Hide resolved
starknet_py/utils/typed_data.py Show resolved Hide resolved
starknet_py/utils/typed_data_test.py Show resolved Hide resolved
Base automatically changed from franciszekjob/1353-2-merkletree to development June 27, 2024 14:49
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.77%. Comparing base (345b0ba) to head (5afd511).
Report is 5 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff                @@
##           development    #1369       +/-   ##
================================================
- Coverage        96.97%   86.77%   -10.21%     
================================================
  Files               93       98        +5     
  Lines             4766     4984      +218     
================================================
- Hits              4622     4325      -297     
- Misses             144      659      +515     
Files Coverage Δ
starknet_py/utils/typed_data.py 79.38% <70.58%> (-19.55%) ⬇️

... and 56 files with indirect coverage changes

@franciszekjob franciszekjob merged commit 69b0f33 into development Jun 29, 2024
16 checks passed
@franciszekjob franciszekjob deleted the franciszekjob/1353-3-verify-types branch June 29, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants