Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature parameter to estimate_fee #217

Merged
merged 1 commit into from Jun 23, 2022
Merged

Conversation

cptartur
Copy link
Member

Please check if the PR fulfills these requirements

  • The formatter, linter, and tests all run without an error
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Adds signature parameter to Contract.estimate_fee method

  • What is the current behavior? (You can also link to an open issue here)

Signature is not added

What is the new behavior (if this is a feature change)?

Signature is added to invoke function

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

Other information

n/a

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #217 (f40608a) into development (c3804bb) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           development     #217   +/-   ##
============================================
  Coverage        97.84%   97.84%           
============================================
  Files               29       29           
  Lines              976      976           
============================================
  Hits               955      955           
  Misses              21       21           
Impacted Files Coverage Δ
starknet_py/contract.py 99.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3804bb...f40608a. Read the comment docs.

@cptartur cptartur merged commit 8d3b237 into development Jun 23, 2022
@cptartur cptartur deleted the fix/estimate-fee branch June 23, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants