Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include gas_price in block schema #279

Conversation

antazoey
Copy link
Contributor

@antazoey antazoey commented Aug 1, 2022

Please check if the PR fulfills these requirements

  • The formatter, linter, and tests all run without an error
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Includes property from response gas_price in block schema

  • What is the current behavior? (You can also link to an open issue here)

gas_price is missing from block schema

What is the new behavior (if this is a feature change)?

gas_price is available in the block

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information

@antazoey antazoey force-pushed the feat/jules/block-gas-price branch 2 times, most recently from 0c2ec7a to 1286c59 Compare August 1, 2022 20:32
@war-in
Copy link
Contributor

war-in commented Aug 2, 2022

Thanks for contributing! Tests are failing because RPC doesn't support gas_price in the block (even in the newest specification). The solution could be to create a new dataclass "GatewayBlock" (in the client_models.py) which extends StarknetBlock and adds gas_price field. We don't want to modify the StarknetBlock dataclass, because it's compatible with RPC specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants