New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace data transfomer in some modules #642
Replace data transfomer in some modules #642
Conversation
Codecov ReportBase: 97.98% // Head: 97.80% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## refactor/data-transformer #642 +/- ##
=============================================================
- Coverage 97.98% 97.80% -0.19%
=============================================================
Files 75 75
Lines 3222 3230 +8
=============================================================
+ Hits 3157 3159 +2
- Misses 65 71 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -68,7 +68,7 @@ def parsed_abi(self) -> Abi: | |||
return AbiParser(self.abi).parse() | |||
|
|||
@staticmethod | |||
def from_abi(address: int, abi: ABI) -> "ContractData": | |||
def from_abi(address: int, abi: ABI) -> ContractData: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use __future__.annotations
in this file, so we can use types normally.
from dataclasses import dataclass | ||
from typing import Dict, Optional | ||
from typing import Dict, Optional, OrderedDict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need OrderedDict type here (not class) :|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
constructor_abi = next( | ||
(member for member in abi if member["type"] == "constructor"), | ||
None, | ||
) | ||
parsed = AbiParser(abi).parse() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
* Add cairo type parser (#566) * Add ABI module (#571) * Add transformation context (#576) * Add TupleDataclass (#590) * Add cairo.serializer module (#593) * Add fix to nested errors (#599) * Feat/payload serializer (#601) * Add tuple serializers (#612) * Add struct & uin256 serilaizer (#613) * Add FunctionSerializationAdapter (#614) * Add cycle check in parser (#630) * Add serializer factory functions (#629) * Use new serializer in contract (#637) * Replace data transfomer in some modules (#642) * Replace data transfomer in some modules * Simplify structure in account * Remove more dependencies on data_transfomer * Remove string typed types in contract * Cover missing statements (#648) * Cover missing statements * Change deprecation text in felt.py * Update starknet_py/cairo/type_parser.py Co-authored-by: war-in <61014013+war-in@users.noreply.github.com> Co-authored-by: war-in <61014013+war-in@users.noreply.github.com> * Add missing dots (#652) * Deprecate data_transformer module (#654) * Add simple examples in documentation of serializers (#653) * Add test for complex abi (#663) * Support {low, high} dict in uint256 serializer (#668) * Support {low, high} dict in uint256 serializer * Replace ^ with ** * Add basic docs for serializers (#679) * Add basic docs for serializers * Add more docs * Adjust comment * Move abi and serialization to top level modules * Add TupleDataclass to api * Fix docs * Fix serializing example * Fix lint * Use header consistent with the rest of the api * Remove unnecessary pylint disable, unify disables * Update comment * Format * Update docs/guide/serialization.rst Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com> Co-authored-by: Artur Michalek <artur.michalek@swmansion.com> Co-authored-by: Artur Michałek <52135326+cptartur@users.noreply.github.com> Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com> * Apply suggestions from code review Co-authored-by: war-in <61014013+war-in@users.noreply.github.com> * Make deployer.py variables private Co-authored-by: war-in <61014013+war-in@users.noreply.github.com> Co-authored-by: Artur Michalek <artur.michalek@swmansion.com> Co-authored-by: Artur Michałek <52135326+cptartur@users.noreply.github.com> Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
No description provided.