Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document missing API (hash and client_models) #914

Merged
merged 3 commits into from Mar 31, 2023
Merged

Document missing API (hash and client_models) #914

merged 3 commits into from Mar 31, 2023

Conversation

war-in
Copy link
Collaborator

@war-in war-in commented Mar 31, 2023 •
edited

Closes #912
Closes #905

Introduced changes

  • Hash module and client_modelss are documented

  • This PR contains breaking changes

@war-in war-in requested review from cptartur and drknzz March 31, 2023 07:26
drknzz
drknzz approved these changes Mar 31, 2023
View reviewed changes
starknet_py/net/client_models.py Outdated Show resolved Hide resolved
starknet_py/net/client_models.py Show resolved Hide resolved
@war-in @drknzz
Update starknet_py/net/client_models.py
0460ea8 
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
@war-in war-in merged commit 71d51aa into development Mar 31, 2023
4 checks passed
@war-in war-in deleted the docs/document-missing-api branch March 31, 2023 10:09
@drknzz drknzz mentioned this pull request Mar 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cptartur cptartur cptartur approved these changes

@drknzz drknzz drknzz approved these changes

Assignees

@war-in war-in

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document SentTransactionResponse Add hash section to API docs
3 participants
@war-in @cptartur @drknzz