Use enums for basic and preset types in StarknetTypedData
#180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `dataAvailability` to `StarknetExecutionResources`; Add `StarknetDataAvailability - Add `executionResources` to tx traces - Add `StarknetComputationResources` - Add `computationResources` to `StarknetFunctionInvocation` - Add `StarknetResources` protocol with common fields
- Prefund account with `5_000_000_000_000_000`->`5_000_000_000_000_000_000` - Change max fee in declare methods to `1_000_000_000_000_000`->`10_000_000_000_000_000`
- Add `dataGasConsumed`, `dataGasPrice` fields to `StarknetFeeEstimate` - Update `.toResourceBounds()` extension - Update overheads - Use new logic
… and `StarknetExecutionResources` - Adjust tests
- Add `StarknetTypedData.Domain`, `StarknetTypedData.Revision` - Change `domain` type: `[String: Element] -> Domain` - Update initializer - Add `getStructHash(typeName: String, data: Data)` - Add `getStructHash(domain: Domain)`
- Use correct escape chars for rev 1
- Rename test files `typed_data_[..].json`-> `typed_data_rev_0_[..].json` - Add `typed_data_rev_1_example.json` - Update `TypedDataTests` - Move old td cases to `CasesRev0` - Add `CasesRev1`
…otocol - Add `TypeDeclarationWrapper` - Change `types` type from `[String: [TypeDeclaration]]` to `[String: [TypeDeclarationWrapper]]`
DelevoXDG
force-pushed
the
feat/159-8-preset-types
branch
from
05ced26
to
726c183
Compare
DelevoXDG
force-pushed
the
feat/159-9-typesafe-reserved-types
branch
from
10351c4
to
0cfe884
Compare
THenry14
approved these changes
Apr 5, 2024
| guard let context else { | ||
| throw StarknetTypedDataError.contextNotDefined | ||
| } | ||
| return try prepareMerkleTreeRoot(from: element, context: context) | ||
| default: | ||
| case (.some, .v0): | ||
| throw StarknetTypedDataError.unsupportedType(typeName) |
There was a problem hiding this comment.
InsupportedType makes sense here, I'd just leave it as is
1 task
DelevoXDG
force-pushed
the
feat/159-9-typesafe-reserved-types
branch
from
021b8a1
to
2901de6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack
StarknetTypedDatarevision 1 #166StarknetMerkleTreeandmerkletreesupport inStarknetTypedData#167StarknetTypedDatain line with SNIP-12 #170bool,ClassHash,ContractAddressbasic types inStarknetTypedData#173Felt(fromSigned)initializer; Supportu128,i128,timestamptypes inStarknetTypedData#174StarknetByteArray; Support revision 1stringinStarknetTypedData#175enumbasic type inStartknetTypedData#178StarknetTypedData#182StarknetTypedData#180StarknetTypedDatadocs (SNIP-12) #181Describe your changes
Refactor
StarknetTypedDatato use enums for basic and preset types instead of raw strings inStarknetTypedDatato ensure type safetyLinked issues
Closes
Breaking changes