-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support batching multiple RPC requests #187
Merged
Merged
Changes from all commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
d020773
Add possibility of`id` modification in `JsonRpcPayload`
franciszekjob 9f82f76
Merge branch 'main' of https://github.com/software-mansion/starknet.s…
franciszekjob b598af7
Refactor sending rpc request for `specVersion`
franciszekjob b6b9a40
Format
franciszekjob 3801260
Add generic type of `params` in `HttpRequest` and `buildRequest`
franciszekjob a1d84d2
Refactor method signatures to return `HttpRequest`
franciszekjob b53eef0
Remove `makeRequest` and update methods to use `buildRequest`
franciszekjob 5be5ad4
Change access levels of request param types
franciszekjob 2af15e7
Update usage of `StarknetProvider` endpoints in tests
franciszekjob 53879fc
Format
franciszekjob 0adb281
Move`HttpRequest`. Add `HttpBatchRequest` and `Request`
franciszekjob f9df81b
Add `batchRequests` method
franciszekjob b00296b
Add `testBatchGetTransactionByHash` test
franciszekjob a2739d2
Update `testBatchGetTransactionByHash`
franciszekjob f681f58
Rename request files
franciszekjob 00a123f
Remove `batchRequests` from `StarknetProviderProtocol`
franciszekjob d0b66f0
Order responses ordering
franciszekjob bfb3b25
Add `batchRequests` with variadic param `requests`
franciszekjob 871aefc
Fix wrong variable name
franciszekjob 1a74d7b
Update `testBatchGetTransactionByHash` test
franciszekjob 33071cf
Merge branch 'main' of https://github.com/software-mansion/starknet.s…
franciszekjob 2fd5b3b
Wrap values returned from `batchRequests` in `Result`
franciszekjob 1beafcb
Add different transactions to `testBatchGetTransactionByHash`
franciszekjob 697d340
Format
franciszekjob af2b884
Add incrementing `id` in json rpc requests
franciszekjob 56f9916
Refactor `batchRequests`
franciszekjob c6554a4
Use variadic params in `testBatchGetTransactionByHash`
franciszekjob 917e8c9
Refactor `send` in `BatchRequest`
franciszekjob ebb791b
Remove mistakenly copied `BatchRequest` class
franciszekjob 05f7cdd
Refactor `send` and `sendbatch` methods in `HttpNetworkProvider`
franciszekjob 53dd8d2
Add methods for encoding and response error handling to `HttpNetworkP…
franciszekjob a0de208
Change `handleEncodeError` to `handleEncodingError`
franciszekjob 199657b
Merge branch 'main' of https://github.com/software-mansion/starknet.s…
franciszekjob fdee240
Update .gitignore
franciszekjob 38c1773
Change return type of `StarknetAccount` methods to `Request`
franciszekjob 4d77998
Merge branch 'feat/186-batch-multiple-rpc-requests' of https://github…
franciszekjob 6811c24
Add `Starknet` prefix to `Request` and `BatchRequest`
franciszekjob 55cc253
Restore let id in `JsonRpcPayload`
franciszekjob a9c3113
Verify error in `testBatchGetTransactionByHash`
franciszekjob 85d70fc
Add test for json rpc responses with incorrect order
franciszekjob 21bdc4b
Remove redundant constructors from request structs
franciszekjob 0ac08b1
Add `StarknetProvider` extension; Move there `getHttpRequestConfigura…
franciszekjob d96c19f
Add separate provider for batching request tests
franciszekjob 3e261bc
Update doc comments
franciszekjob 48b7fe9
Merge branch 'main' into feat/186-batch-multiple-rpc-requests
franciszekjob 3e8c6d3
Rename `getHttpRequestConfiguration()` to `prepareHttpRequestConfigur…
franciszekjob 3438030
Merge branch 'feat/186-batch-multiple-rpc-requests' of https://github…
franciszekjob ed32ad6
Add `HttpNetworkProvider.encodePayload()`
franciszekjob f7d6f9a
Add `EncodableParams`
franciszekjob 0f74e6c
Merge branch 'main' into feat/186-batch-multiple-rpc-requests
franciszekjob 7f8749e
Update doc comment; Add `emptyRequestList` error
franciszekjob fbc89d9
Remove `public` from `encode()` methods
franciszekjob 35ae6a2
Restore `EstimateMessageFeeParams` as public
franciszekjob 64c9742
Rename `specVersion()` to `getSpecVersion()`
franciszekjob 50f4ad7
Update Sources/Starknet/Network/StarknetRequest.swift
franciszekjob cb8cff3
Update Sources/Starknet/Network/StarknetBatchRequest.swift
franciszekjob 161731a
Minor naming changes
franciszekjob a5ddd1e
Merge branch 'feat/186-batch-multiple-rpc-requests' of https://github…
franciszekjob 4ea34f7
Update Sources/Starknet/Providers/StarknetProvider/JsonRpcParams.swift
franciszekjob 5cfd536
Update `JsonRpcParams` cases naming; Remove `wrappedExecutableTransac…
franciszekjob 94c718d
Move request batching methods to `StarknetProviderProtocol`
franciszekjob f5c82d4
Refactor `orderRpcResults`; Remove `batchProvider`
franciszekjob File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure getting the first estimate is a valid approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been discussed in previous thread
#187 (comment)