Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃搩 Remove LayoutManagerFactory #252

Merged

Conversation

softwareantics
Copy link
Owner

@softwareantics softwareantics commented Aug 15, 2023

Description

  • Removed ILayoutManagerFactory.
  • Removed LayoutManagerFactory.
  • Moved caching field to LayoutManager.
  • XamlLayoutSerializer is created when required, not within the constructor.
  • Updated references to not use ILayoutManagerFactory and instead use ILayoutManager directly.
  • Updated existing unit tests.

Fixes #247

Dependencies

This PR introduces no new dependencies.

Type of change

  • Other: Small Task to improve code-base.

How Has This Been Tested?

I've updated all existing unit tests and ensured they all pass locally on my machine. I also ran the editor application and ensured that all layout management functionality is working as expected.

Test Configuration:

  • Operating System: Windows 10 Home
  • Hardware: Intel i7-6700HQ, 16GB, GTX 950M
  • Toolchain: VS Community 2022 17.5.4

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings

@softwareantics softwareantics self-assigned this Aug 15, 2023
@softwareantics softwareantics changed the base branch from develop to epic/112-editor August 15, 2023 12:13
@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2023

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@softwareantics softwareantics merged commit a1cec3b into epic/112-editor Aug 15, 2023
3 checks passed
@softwareantics softwareantics deleted the task/247-remove-layout-manager-factory branch August 15, 2023 12:23
This was referenced Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

馃搩 Remove LayoutManagerFactory
1 participant