Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdopkg new-version do not entertain short %macros in Name: #161

Closed
karelyatin opened this issue Aug 21, 2018 · 1 comment
Closed

rdopkg new-version do not entertain short %macros in Name: #161

karelyatin opened this issue Aug 21, 2018 · 1 comment
Assignees

Comments

@karelyatin
Copy link

Detected in:- https://review.rdoproject.org/r/#/c/15777/1 and https://review.rdoproject.org/r/#/c/15772/1

If spec contains macro in Name:,

rdopkg new-version -U -b will add the macro(without expansion) in the commit message.

For example:-
%global library kuryr-lib
Name: python-%library

rdopkg new-version -U -b 0.8.0 will add following commit message:-

python-%library-0.8.0-1

Changelog: -
Update to 0.8.0

@yac yac self-assigned this Aug 21, 2018
@yac yac changed the title rdopkg new-version do not entertain macros in Name: rdopkg new-version do not entertain short %macros in Name: Nov 15, 2018
@yac
Copy link
Contributor

yac commented Nov 15, 2018

So this was just a bad detection of short macros fixed by https://softwarefactory-project.io/r/#/c/14252/ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants