Added Logout button #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edithemmings
reviewed
Apr 4, 2024
edithemmings
reviewed
Apr 4, 2024
edithemmings
reviewed
Apr 4, 2024
edithemmings
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Nice work! Looks like its working as-is. I provided an alternative option where you don't have to create a custom devise route. I think it is a cleaner approach. But I will let you and @camckin10 decide.
camckin10
previously approved these changes
Apr 8, 2024
There was a problem hiding this comment.
This looks great Kenyon!
Thank you @edithemmings for the suggestion about cleaning up the scope code.
Before you merge please:
--resolve all conversations on your PR
--Update your ticket description to include that you were able to make the route work.
--Change your PR from draft to ready to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Give a short summary of the changes made in this PR.
Link to Issue
Link Asana ticket here!
Comments, Notes, or Questions
I added the button to the sidebar. Now I am working on getting it to redirect to the sign in page.
Related Screenshots
For FE tickets specifcially, please include a screenshot of your work!
routes are working.
Before you submit for review, Did you...