Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding insertion and deletion metrics #76

Merged
merged 17 commits into from
Jun 29, 2023
Merged

Adding insertion and deletion metrics #76

merged 17 commits into from
Jun 29, 2023

Conversation

rpytel1
Copy link
Collaborator

@rpytel1 rpytel1 commented Apr 12, 2023 •
edited
Loading

Description

Introducing Deletion and Insertion metric to FoXAI.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Test A
  • Test B

Checklist:

  • I have updated all related pyproject.toml files.
  • I have updated lock files.
  • I have set an Assignee and Reviewers.
  • I have labeled the PR correctly.
  • I have performed a self-review of my own code.
  • I have covered my code and changes with unit tests.
  • I have annotated types as extensively as possible.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • All code references and dependencies will work.

@rpytel1 rpytel1 self-assigned this Apr 12, 2023
@rpytel1 rpytel1 added the enhancement New feature or request label Apr 12, 2023
@rpytel1 rpytel1 added this to the version 0.6 milestone Apr 12, 2023
This was linked to issues Apr 12, 2023
[Feature] Add Insertion metric #71
Closed
[Feature] Add Deletion metric #72
Closed
kamilrzechowski
kamilrzechowski reviewed Apr 26, 2023
View reviewed changes
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
adamwawrzynski
adamwawrzynski approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@adamwawrzynski adamwawrzynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
foxai/metrics/metrics.py Outdated Show resolved Hide resolved
rpytel1 and others added 9 commits May 9, 2023 09:56
@rpytel1 @adamwawrzynski
Update foxai/metrics/metrics.py
93b0c0b 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@rpytel1 @adamwawrzynski
Update foxai/metrics/metrics.py
a4576da 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@rpytel1 @adamwawrzynski
Update foxai/metrics/metrics.py
fa36fa7 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@rpytel1 @adamwawrzynski
Update foxai/metrics/metrics.py
064cc78 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@rpytel1 @adamwawrzynski
Update foxai/metrics/metrics.py
39179c8 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@rpytel1 @adamwawrzynski
Update foxai/metrics/metrics.py
94ee5d3 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@rpytel1 @adamwawrzynski
Update foxai/metrics/metrics.py
35fa55a 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@rpytel1 @adamwawrzynski
Apply suggestions from code review
3310754 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@rpytel1
Removing extra files added before as a mistake
1eb9433
@rpytel1
Copy link
Collaborator Author

rpytel1 commented May 9, 2023

After we finish review of this PR, we need to discuss whether it can be merged or perhaps #75 should be merged first as it has quite some breaking changes with other PRs.

@rpytel1 rpytel1 force-pushed the feature/del_insert_metrics branch from 0dd11dd to b2706e9 Compare May 10, 2023 08:18
@rpytel1 rpytel1 force-pushed the feature/del_insert_metrics branch from b2706e9 to 02b0197 Compare May 10, 2023 11:57
@rpytel1 rpytel1 merged commit 76278fe into main Jun 29, 2023
4 checks passed
@rpytel1 rpytel1 deleted the feature/del_insert_metrics branch June 29, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilrzechowski kamilrzechowski kamilrzechowski left review comments

@adamwawrzynski adamwawrzynski adamwawrzynski approved these changes

@adamjankaczmarek adamjankaczmarek Awaiting requested review from adamjankaczmarek

Assignees

@rpytel1 rpytel1

Labels
enhancement New feature or request
Projects
None yet
Milestone
version 0.6
Development

Successfully merging this pull request may close these issues.

[Feature] Add Deletion metric [Feature] Add Insertion metric
3 participants
@rpytel1 @adamwawrzynski @kamilrzechowski